[slayer] change .env #246
Merged
[slayer] change .env #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luxian <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the .env configuration file for slayerfs to replace MinIO-specific references with a generic "rustfs" storage backend, aligning the project with a different S3-compatible service.
Key changes:
- Updated AWS credentials from
minioadmintorustfsadmin - Replaced MinIO setup instructions with rustfs installation and configuration steps
Comment on lines
+18
to
+19
| # 1. Install rustfs: curl -O https://rustfs.com/install_rustfs.sh && bash install_rustfs.sh | ||
| # 2. Ensure rustfs S3-compatible endpoint is running at http://127.0.0.1:9000 |
There was a problem hiding this comment.
Piping a downloaded script directly to bash without verification is a security risk. Consider adding instructions to verify the script's integrity (e.g., checksum verification) or recommend reviewing the script before execution.
Suggested change
| # 1. Install rustfs: curl -O https://rustfs.com/install_rustfs.sh && bash install_rustfs.sh | |
| # 2. Ensure rustfs S3-compatible endpoint is running at http://127.0.0.1:9000 | |
| # 1. Install rustfs: |
| # 3. Or use AWS CLI: aws --endpoint-url http://localhost:9000 s3 mb s3://slayerfs | ||
| # 1. Install rustfs: curl -O https://rustfs.com/install_rustfs.sh && bash install_rustfs.sh | ||
| # 2. Ensure rustfs S3-compatible endpoint is running at http://127.0.0.1:9000 | ||
| # 3. Create bucket using s3 client or web console at http://localhost:9001 |
There was a problem hiding this comment.
Capitalization inconsistency: 's3' should be 'S3' to match standard AWS terminology and the convention used elsewhere in the file.
Suggested change
| # 3. Create bucket using s3 client or web console at http://localhost:9001 | |
| # 3. Create bucket using S3 client or web console at http://localhost:9001 |
genedna
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.